From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Wed, 6 Nov 2024 17:08:02 +0000 (-0700)
Subject: hide logging member variables, use references for stream op. (#1369)
X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2^2~21
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22Program/%22http:/www.example.com/cgi/%22https:/%22Program?a=commitdiff_plain;h=dfadba0a59c3adaf18a2e1f0cca86da2c276f7c6;p=gpsbabel.git

hide logging member variables, use references for stream op. (#1369)

* hide logging member variables, use references for stream op.

* match parameter naming.

* longer names.
---

diff --git a/src/core/logging.cc b/src/core/logging.cc
index f6e1a31d6..722bc0617 100644
--- a/src/core/logging.cc
+++ b/src/core/logging.cc
@@ -22,9 +22,9 @@
 #include "src/core/logging.h"
 
 
-QDebug operator<< (QDebug debug, const DebugIndent& indent)
+QDebug& operator<< (QDebug& debug, const DebugIndent& indent)
 {
-  for (int i = 1; i<indent.level; i++) {
+  for (int i = 1; i<indent.level_; i++) {
     debug << '.';
   }
   return debug;
diff --git a/src/core/logging.h b/src/core/logging.h
index a41733752..64f84ea64 100644
--- a/src/core/logging.h
+++ b/src/core/logging.h
@@ -52,18 +52,20 @@ public:
 class DebugIndent
 {
 public:
-  explicit DebugIndent(int l) : level(l) {}
+  explicit DebugIndent(int level) : level_(level) {}
+  friend QDebug& operator<<(QDebug& debug, const DebugIndent& indent);
 
-  int level;
+private:
+  int level_;
 };
 
-QDebug operator<< (QDebug debug, const DebugIndent& indent);
+QDebug& operator<< (QDebug& debug, const DebugIndent& indent);
 
 class Debug : public QDebug
 {
 public:
   Debug() : QDebug(QtDebugMsg) {nospace().noquote();}
-  explicit Debug(int l) : QDebug(QtDebugMsg) {nospace().noquote() << DebugIndent(l);}
+  explicit Debug(int level) : QDebug(QtDebugMsg) {nospace().noquote() << DebugIndent(level);}
 };
 
 #endif //  SRC_CORE_LOGGING_H_